search

AnthonyMichaelTDM / DRG-Save-Editor

Rock and stone!
GNU General Public License v3.0
115 stars 17 forks source link

Add tests #99

Closed wahlp closed 3 months ago

wahlp commented 3 months ago

resolves #78

wahlp commented 3 months ago

@AnthonyMichaelTDM @simon-wg

might be a good opportunity to standardise our development tools.

the CI calls for flake8 and mypy but i'm not sure if you guys are using anything else on top of that. feel free to add to requirements-dev.txt

AnthonyMichaelTDM commented 3 months ago

requirements-dev.txt looks good, flake8, mypy, and pytest are the standard tools for this project (and all my other python work)

AnthonyMichaelTDM commented 3 months ago

let's also go through some of the closed issues (that provided saves) and write tests to ensure that their issues were fixed, for cases where doing that makes sense

simon-wg commented 3 months ago

Looks good, I also use black for formatting, which I'd recommend as well.