Rolls from Character and Monster sheet - two bugs

[Dillatr]

Clicking a skill to roll requires an actor to be selected, whereas before it didnt need an actor to be selected. Any token can be selected, even tokens not related to the character/monster sheet.

Also, criticals/fumbles in chat rolls no longer show the button to do the reroll

[Dillatr]

bugs appeared after version 0.95

[Dillatr]

fumble and crit automatic rolls work correctly for STATS but not skills

[MaxAlvin]

I have the same bug

[MaxAlvin]

and a weapon with the "improved armor piercing" property simply ignores it

[MaxAlvin]

some weapons stop works... and more other. how do I roll back to the previous version?

[AnthonyMonette]

A fix has been pushed, could you both confirm if everythings good now?

[Dillatr]

Fumble and crit work correctly (however fumbles include the 1 from the initial d10 in the total check) Had issues with damage not subtracting armor SP from character tokens, but works correctly for monster tokens (doesn't matter if weapon has armor piercing / improved armor piercing / no armor piercing)

[Dillatr]

Tokens dont need to be selected to roll from a character sheet, however the error message still shows up

[Galonas]

Fumble and crit work correctly (however fumbles include the 1 from the initial d10 in the total check) Had issues with damage not subtracting armor SP from character tokens, but works correctly for monster tokens (doesn't matter if weapon has armor piercing / improved armor piercing / no armor piercing)

I had the same problem and I found the problem. I made a push request for the correction, thanks

[Melkkart]

Tu corre

La pifia y el crítico funcionan correctamente (sin embargo, las pifias incluyen el 1 del d10 inicial en la comprobación total) Tuvo problemas con el daño que no restaba SP de armadura de las fichas de personaje, pero funciona correctamente para fichas de monstruo (no importa si el arma tiene perforación de armadura / mejorada perforación de armadura / sin perforación de armadura)

Tuve el mismo problema y encontré el problema. Hice una solicitud de inserción para la corrección, gracias

Thks, I Fix the problem :)

[pedroaugustobt]

Does anyone know if it's been fixed yet? It's still happening to me

[Melkkart]

Hello, they haven't uploaded it yet, but I'll give you the corrected file. https://drive.google.com/file/d/1wFlDMeiI6d0MqgLzHr7AbDilPJwzF9TJ/view?usp=sharing replace the file route: C:\Users\YOUUSER\AppData\Local\FoundryVTT\Data\systems\TheWitcherTRPG\scripts

[pedroaugustobt]

Thanks, i was trying to find an answer but i couldn't, thanks again

Em seg., 20 de mar. de 2023 13:43, Melkkart @.***> escreveu:

Hello, they haven't uploaded it yet, but I'll give you the corrected file.

https://drive.google.com/file/d/1wFlDMeiI6d0MqgLzHr7AbDilPJwzF9TJ/view?usp=sharing replace the file route: C:\Users\YOUUSER\AppData\Local\FoundryVTT\Data\systems\TheWitcherTRPG\scripts

— Reply to this email directly, view it on GitHub https://github.com/AnthonyMonette/TheWitcherTRPG/issues/282#issuecomment-1476582749, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZS2SHZOJCXKWZYQUXS767LW5CCMBANCNFSM6AAAAAATPPOQUI . You are receiving this because you commented.Message ID: @.***>

[Galonas]

Thanks, i was trying to find an answer but i couldn't, thanks again Em seg., 20 de mar. de 2023 13:43, Melkkart @.> escreveu: … Hello, they haven't uploaded it yet, but I'll give you the corrected file. https://drive.google.com/file/d/1wFlDMeiI6d0MqgLzHr7AbDilPJwzF9TJ/view?usp=sharing replace the file route: C:\Users\YOUUSER\AppData\Local\FoundryVTT\Data\systems\TheWitcherTRPG\scripts — Reply to this email directly, view it on GitHub <#282 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZS2SHZOJCXKWZYQUXS767LW5CCMBANCNFSM6AAAAAATPPOQUI . You are receiving this because you commented.Message ID: @.>

Sorry, I thought you could see what's in my pull request and make the change on your side...I'm still waiting for it to be integrated.

[pedroaugustobt]

Thanks, i was trying to find an answer but i couldn't, thanks again Em seg., 20 de mar. de 2023 13:43, Melkkart @.**> escreveu: … Hello, they haven't uploaded it yet, but I'll give you the corrected file. https://drive.google.com/file/d/1wFlDMeiI6d0MqgLzHr7AbDilPJwzF9TJ/view?usp=sharing replace the file route: C:\Users\YOUUSER\AppData\Local\FoundryVTT\Data\systems\TheWitcherTRPG\scripts — Reply to this email directly, view it on GitHub <#282 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZS2SHZOJCXKWZYQUXS767LW5CCMBANCNFSM6AAAAAATPPOQUI . You are receiving this because you commented.Message ID: @.**>

Sorry, I thought you could see what's in my pull request and make the change on your side...I'm still waiting for it to be integrated.

No problem, i was trying to repair the code for myself, but i found this git and make easy my life, thank helping!!! Edit: Sorry for my English, I'm Brazilian and I'm learning to communicate.

[1991Dmitriy]

SP is still not working. I saw the file but did not find where to copy it, the actions file.

[ortegamarcel]

If you want, you can try out my "development" version. I am (currently) more active and have time to fix such issues.

This version fixed the problem with the armor not being applied and has some more features like Improved Inventory and Zoomable Images. I also created pull requests here, but they are not merged (available) yet. That version is also compatible with the Token Action HUD TheWitcherTRPG.

[Durins-Cat]

I am having the "At least one actor must be selected" issue when trying to roll from a character sheet. Works fine if i have an actor selected but i'd like to figure out a way to have it work like normal. I tried installing ortegamarcel's fork and the action script file above, but neither solves the issue. (Foundry vs. 11 Stable - Build 315)