search

AnthonyMonette / TheWitcherTRPG

FoundryVTT The witcher trpg system
GNU General Public License v3.0
29 stars 34 forks source link

Crit does not work when attacking with a weapon from the inventory #296

Open dam1ch opened 1 year ago

dam1ch commented 1 year ago

When I open my inventory and want to throw a weapon, I notice that my character doesn't crit when the dice roll "1" and "10". Only 1 die is rolled, and no additional dice. How to fix it?

Melkkart commented 1 year ago

Hi @dam1ch I think I have fixed the bug, it was easy, but we will have to test it. I will upload the corrected file to the cloud. Path of the file to replace: C:\Users\xxxx\AppData\Local\FoundryVTT\Data\systems\TheWitcherTRPG\module File name rollConfig.js Download: https://drive.google.com/file/d/1CFIRehiux507Os12ImBfOr3jVCWKg_C2/view?usp=share_link

Note: The showCrit and ShowSuccess function, I have changed them from "false" to "True". I don't know much about programming, but I guess that any roll made now, will use the critical rule.

LinkDragmire commented 1 year ago

the crit not longer are stated as dice formula (can't see rolled numbers via click and tooltip or 3d dice) due to the reversable attribute. this update seems to be tha cause for the not working crits