Issue with enchanted item rolls

AnthonyMonette / TheWitcherTRPG

FoundryVTT The witcher trpg system

GNU General Public License v3.0

28 stars 35 forks source link

Issue with enchanted item rolls #313

Closed pedroaugustobt closed 1 year ago

pedroaugustobt commented 1 year ago

I have a problem, when I put an enchanted item on the weapon, the dice roll does not work.

this is the bug that appears: Captura de tela 2023-07-09 204250

Uncaught (in promise) TypeError: undefined. Cannot read properties of undefined (reading 'quantity') [Detected 1 package: system:TheWitcherTRPG] at Array.sum (WitcherActorSheet.js:94:45) at WitcherActorSheet._onItemRoll (WitcherActorSheet.js:2052:34) at HTMLAnchorElement.dispatch (jquery.min.js:2:43064) at y.handle (jquery.min.js:2:41048)

Melkkart commented 1 year ago

It works fine for me, try the version with the improvements made by Ortegamarcel and Pkonshik, if you don't want to make all the changes, here is the system. https://drive.google.com/file/d/15VY9Yti3UqaLuRqkYtTK7Z4SduLOD9bL/view?usp=sharing

AnthonyMonette commented 1 year ago

@pedroaugustobt can you confirm if with the latest version it works properly?

pedroaugustobt commented 1 year ago

@pedroaugustobt can you confirm if with the latest version it works properly?

Yes, working in latest version! I have some fixes about glyphs and focus. Can i send pull?

AnthonyMonette commented 1 year ago

Yes, of course, Im gonna close this issue and Ill take a look at your PR once it will be send Thanks!