AnthonyNahas / ngx-auth-firebaseui

Angular Material UI component for firebase authentication
https://ngx-auth-firebaseui.firebaseapp.com
MIT License
589 stars 165 forks source link

failed to update to angular 11 #604

Closed Vegita2 closed 2 years ago

Vegita2 commented 3 years ago

Bug Report or Feature Request (mark with an x)

- [X] bug report -> please search issues before submitting
- [ ] feature request

OS and Version?

Ubuntu 20.10

Repro steps

I tried to update my project to use angular 11, but couldn't because npm failed to resolve the dependency tree.

Package.json

...
"dependencies": {
    "@angular/animations": "~11.0.7",
    "@angular/cdk": "^11.0.3",
    "@angular/common": "~11.0.7",
    "@angular/compiler": "~11.0.7",
    "@angular/core": "~11.0.7",
    "@angular/fire": "^6.1.4",
    "@angular/flex-layout": "^11.0.0-beta.33",
    "@angular/forms": "~11.0.7",
    "@angular/material": "^11.0.3",
    "@angular/platform-browser": "~11.0.7",
    "@angular/platform-browser-dynamic": "~11.0.7",
    "@angular/router": "~11.0.7",
    "@ionic/angular": "^5.5.2",
    "@ngneat/until-destroy": "^8.0.3",
    "firebase": "^8.2.2",
    "ngx-auth-firebaseui": "^5.0.1",
    "rxjs": "~6.5.4",
    "tslib": "^2.0.0",
    "zone.js": "~0.10.3"
}
...

The log given by the failure

npm install

npm ERR! Found: @angular/cdk@11.0.3
npm ERR! node_modules/@angular/cdk
npm ERR!   @angular/cdk@"^11.0.3" from the root project
npm ERR!   peer @angular/cdk@"^11.0.0" from ngx-auth-firebaseui@5.0.1
npm ERR!   node_modules/ngx-auth-firebaseui
npm ERR!     ngx-auth-firebaseui@"^5.0.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/cdk@"^10.1.3" from @angular-material-extensions/password-strength@7.0.0
npm ERR! node_modules/@angular-material-extensions/password-strength
npm ERR!   peer @angular-material-extensions/password-strength@"^7.0.0" from ngx-auth-firebaseui@5.0.1
npm ERR!   node_modules/ngx-auth-firebaseui
npm ERR!     ngx-auth-firebaseui@"^5.0.1" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

It seems like updating @angular-material-extensions/password-strength to ^8.0.0 should fix the issue

AnthonyNahas commented 3 years ago

which version of the lib are you using ?

Vegita2 commented 3 years ago

I tried to use the latest 5.0.1

furlongce commented 3 years ago

@AnthonyNahas We're running into this too, with 5.1.0. We have a pressing need to update to Firebase 8+ to avoid a PRD issue, but we're blocked by this.

stevenhatfield commented 3 years ago

Same here @AnthonyNahas ... it's the v7 password-strength dependency that has a peer dependency on Angular v10, which it can't find. It should be easy enough to update it to v8, which works with Angular v11. This is happening in ngx-auth-firebaseui v5.1.0

Dehfw commented 3 years ago

I created a PR where i upgraded the version of password-strength to ^8.0.0 Can someone validate this fix?

https://github.com/AnthonyNahas/ngx-auth-firebaseui/pull/615

carmelneta commented 3 years ago

Hey, Any plans for fixing this soon ? Thanks

AnthonyNahas commented 2 years ago

this is already fixed