Closed Greavox closed 6 years ago
A great idea!
Do you think it is possible/fast enough to show the info in the Main Window after the user selects a savegame? Because it seems odd to me that each character has a game info tab.
If you could review and fix the issues I mentioned in the comments, let's merge it and we will think about the above later.
Thanks!
Do you think it is possible/fast enough to show the info in the Main Window after the user selects a savegame? Because it seems odd to me that each character has a game info tab.
Yes, I wanted to do that but we need to access to meta.lsf=>meta.lsx that packed into SavegameName.lsv and if we need to access to it, we need to unpack each of savegame:
In the first case, it a little long but I can do a built with that to test. In the second, it's too long if savegames are numerous
I suspend this request and warn you when I have test that with your recommendation
@Greavox commented on May 20, 2018, 2:10 PM GMT+1:
Do you think it is possible/fast enough to show the info in the Main Window after the user selects a savegame? Because it seems odd to me that each character has a game info tab.
Yes, I wanted to do that but we need to access to meta.lsf=>meta.lsx that packed into SavegameName.lsv and if we need to access to it, we need to unpack each of savegame:
- either on savegame select event
- either on savegame list load
In the first case, it a little long but I can do a built with that to test. In the second, it's too long if savegames are numerous
I suspend this request and warn you when I have test that with your recommendation
I think it takes about a second on my PC, but still it would be too long for a sync method. We could use an async method with a message says loading
while it is doing the drill, and the user can decide whether he wants to wait for the information to confirm what he is going to edit.
OK, I think I will merge it tonight (GMT 18:00-ish) and make some necessary changes, then publish it with some bug fixes.
Let me know if you are still working on this PR and would need more time by then.
Sorry for this short notice, but I will become busy soon 😢.
You can wait if you want, I'm busy too and I haven't time to work on this now. So don't worry about it ^^
And make all modification you want!
OK, don't worry. What you have done is great already. I will fix the rest 😀
A new tab is created and showed about Game Info like :
And when the savegame is loaded, a warning appears to warn about multiple game version and presence of mods
This is an image that contains two screenshot melted
This is an archive with executable generated in Debug build D-OS-Test.zip
P.S. Maybe game info like game version can be added to error report after the D-OS version with mods info
PPS Need to check Warning Texts and Game Info Tab Text about grammar and orthography etc... Thanks ^^