AnthonyZJiang / D-OS-Save-Editor

A save editor for Divinity Original Sin: Enhanced Edition
Other
50 stars 15 forks source link

XmlDocument() memory leak #2

Open AnthonyZJiang opened 6 years ago

AnthonyZJiang commented 6 years ago

Issue: Memory usage can become hugh (>1G) once a big savegame is loaded. It gets doubled when edits are being saved to savegame. This memory, however, is only released after the application is closed.

Cause: The LSX content loaded using XmlDocument().Load does not get disposed properly after all references to the object are destroyed.

Possible fix: use XmlRead instead of XmlDocument.