AnthroGraph / Phaleron-AppOntology

Support ontology for the implementation of ontologies for the Phaleron Bioarchaeological Project into AnthroGraph.
0 stars 0 forks source link

Add ROIs attached to "number of fragments"/ "number of unidentified fragments" to ROIGroups restrictions #17

Closed zarquon42b closed 2 years ago

zarquon42b commented 2 years ago

Add ROIs attached to "number of fragments"/ "number of unidentified fragments" to suitable ROIGroups restrictions, so they can be queried in pathology sections as ROIs. This applies to all ROIGroups.

Example: The following classes should appear in the restrictions of PhaleronVertebralColumnROIGroup:

cuboideum commented 2 years ago

The following elements appear in the skeletal 'Inventory section hand and foot' (phaleron-si:AdultHandAndFoot) and apply to both hand and foot regions:

The ROIGroups of the Phaleron-AppOntology that are used in the pathology module differentiate between 'Phaleron upper limb anatomical regions of interest group (phaleron-app:PhaleronUpperLimbROIGroup) and 'Phaleron lower limb anatomical regions of interest group' (phaleron-app:PhaleronLowerLimbROIGroup). This poses the problem that the ROIs listed above relate to both these groups.

I suggest to make the ROIs in question part of both groups with the aim to make them selectable in both tabs 'Arm and hand' and 'Leg and foot'. @zarquon42b: Would this be a good solution in terms of implementation? The downside of this solution would be the possibility to enter redundant information from both the 'Arm and hand' and the 'Leg and foot' tabs, respectively. Is there a better solution that would prevent this?

cuboideum commented 2 years ago

On branch file phaleron-app.owl now contains the updated 'Phaleron skull regions of interest group' and 'Phaleron skull articular regions of interest group'. @zarquon42b: You can use this for testing purposes.

zarquon42b commented 2 years ago

Works well on the skull.

Is there a better solution that would prevent this?

No, at least no easy one. I suggest implementing it with this ambiguity.

cuboideum commented 2 years ago

@zarquon42b The changes from this pull request are also reflected in the robot branch.