Anthrocon-Reg / ubersystem

Anthrocon's Ubersystem - a fork of the MagFest system that handles ticketing, staffing, analytics, volunteers, and tons more
http://anthrocon.org
GNU General Public License v3.0
4 stars 0 forks source link

Excess text in fields prevents payment #46

Closed RigelAC closed 9 years ago

RigelAC commented 9 years ago

Entered large amounts of text in all available text fields, then attempted payment. Payment failed with network error, would not permit payment.

To resolve, should probably add a character limit to all text fields.

EliAndrewC commented 9 years ago

Ahhh, good catch. We don't have limits in our own Postgres database, so I didn't bother putting limits on the text fields. Apparently there's a limit on the size of what we submit to Stripe. A good fix would be to just update our stripe_form custom tag to crop the name length.

kitsuta commented 9 years ago

(oh, that's easy then)

Is this on Stripe's pop-up form? We have somewhat limited control of that form (this is by design - we run CC info through Stripe so we never have to worry about handling it), so this is definitely worth looking into.

RigelAC commented 9 years ago

Yes, failure occurred on Stripe's popup form.

EliAndrewC commented 9 years ago

The relevant template is https://github.com/magfest/ubersystem/blob/master/uber/templates/preregistration/stripeForm.html which is rendered by https://github.com/magfest/ubersystem/blob/master/uber/custom_tags.py#L381

So the two relevant fields are:

We could just update our stripe_form tag and/or template to just cap the length of what we pass to Stripe to whatever Stripe's maximum is.

kitsuta commented 9 years ago

This is now fixed in ac-staging.