Open mirabilos opened 3 years ago
These tests have never been finished.
They seem to be committed as a work in progress. (I suppose so, because there are many comments describing what should be tested, and there are some mistakes in there like:
#inlude "addeditautoprofiledialog.h"
@gombosg
Do you think we should remove or finish them?
I haven't worked too much with tests, so I don't have any opinion about their usability.
Do you think we should remove or finish them?
IMHO if they do not work, then maybe it would be better to not put them on master.
@xgqt
I fully agree with you. :)
But it was done a long time ago, when I was not developing this app.
Discovered during Debian packaging, sorry for terseness, I’m short of time for this.
This is because it’s missing the Qt include directories; other files compile like this:
Compiling with
-DWITH_TESTS=OFF
works, so I’m using that for now, but I’d prefer for tests to run if there are tests, of course ☺Upvote & Fund