AntiMicroX / antimicrox

Graphical program used to map keyboard buttons and mouse controls to a gamepad. Useful for playing games with no gamepad support.
GNU General Public License v3.0
2.36k stars 140 forks source link

Issues with advanced key mapping #276

Open BasedOnPixels opened 2 years ago

BasedOnPixels commented 2 years ago

Is there an existing issue for this?

Current Behavior

-When creating a macro with advanced mapping, trying to insert a 2nd slot, makes it add 2 more instead. (for a total of 3 empty ones)

-When it adds the extra one for the 2nd field, it also resets the mapped key for the controller button (Close advanced and reopen it and it will say that there is nothing assigned)

-Adding a key in front (to the left) of an other one, removes the one to the right

Expected Behavior

-It should add only 1 more slot instead of 2. Clicking the insert button for a 3rd time only adds 1 more slot

-The key shouldn't be reset, in the old AntiMicro it didn't reset either when you put a key in the advanced mapping

Steps To Reproduce

Environment

- OS: Windows 10
- AntiMicroX version: 3.2

Anything else?

Also took a clip which tried to showcase all 3 issues

https://puu.sh/Imn12/f5503cfe82.mp4

Timestamps 3 slots + key being reset 0:05 - 0:30

Adding 2nd key removes previous one 0:30 - 0:55


Upvote & Fund

Fund with Polar

pktiuk commented 2 years ago

Thank you for report. That's great that you added video.

pktiuk commented 2 years ago

Inserting more than one slot is expected functionality implemented in: https://github.com/AntiMicroX/antimicrox/commit/553fdcb43a2ecb57233e077068a691757b1006e3

New slot is inserted before every selected action:

obraz

After clicking insert:

obraz

It's Not a Bug, It's a Feature. :rocket:
But TBH I don't know why it was implemented.