Compatibility with QT5 lower than 5.10 broken again

cobalt2727 commented 5 days ago

Is there an existing issue for this?

[X] I searched the existing issues and did not find anything similar.

Current Behavior

Basically the same issue as https://github.com/AntiMicroX/antimicrox/issues/380 right down to the environment (Ubuntu 18.04, building on latest master).

Expected Behavior

no errors on make

Steps To Reproduce

git clone cmake .. make

Environment

`-/+++++++++++++++++/-.`         ubuntu@oracle-vm
   `/syyyyyyyyyyyyyyyyyyyyyyys/.       ----------------
  :yyyyo/-...............-/oyyyy/      OS: Ubuntu bionic 18.04 aarch64
 /yyys-                     .oyyy+     Host: KVM Virtual Machine (virt-4.2)
.yyyy`                       `syyy-    Kernel: Linux 5.4.0-1102-oracle
:yyyo                         /yyy/    Uptime: 99 days, 7 hours, 44 mins
.yyyy`                       `syyy-    Packages: 1882 (dpkg), 3 (snap)
 /yyys.                     .oyyyo     Shell: bash 4.4.20
  /yyyyo:-...............-:oyyyy/`     Display (QEMU Monitor): 1024x768 @ 75Hz
   `/syyyyyyyyyyyyyyyyyyyyyyys+.       Theme: Ambiance [GTK3]
     `.:/+ooooooooooooooo+/:.`         Icons: ubuntu-mono-dark [GTK3]
                                       Cursor: Adwaita
                                       Terminal: tmux 2.6
                                       CPU: ARM CPU (4)
                                       GPU: RedHat Virtio GPU
                                       Memory: 1.30 GiB / 23.44 GiB (6%)

Anything else?

full error log is extremely long so I've just attached it as a file - if you'd rather I re-ran this without multithreading to make it easier to read, I can do that. install-fail-AntiMicroX.txt

cobalt2727 commented 5 days ago

@pktiuk sorry to bug you with this but I'm guessing the fix is just a repeat of what you did way back in https://github.com/AntiMicroX/antimicrox/pull/382

cobalt2727 commented 5 days ago

slightly more readable (though still obscenely long) error log antimicrox-make-single-thread.txt

pktiuk commented 4 days ago

Hi @cobalt2727,
thank you for report.
Could you tell me why versions lower than 5.10 should be still supported?
This version of library is not supported by QT and is shipped with systems like Ubuntu 18.04, which is also not supported anymore.

cobalt2727 commented 4 days ago

I mean, if it's just not worth the effort to you, fair enough - I can get newer QT5 builds from a PPA pretty easily. 18.04 is technically still supported under the (free for non-commercial use) Ubuntu Pro plan until 2028: https://ubuntu.com/about/release-cycle

pktiuk commented 4 days ago

I think that ensuring compatibility with versions lower than 5.10 is too much hassle for too small number of systems.
It was my mistake, that I forgot to set this requirement in cmake

AntiMicroX / antimicrox