Fix: Declaration of "classes" must be compatible with National

Antidot-be / bpost-api-library

Other

24 stars 19 forks source link

Fix: Declaration of "classes" must be compatible with National #17

Closed basselin closed 5 years ago

basselin commented 5 years ago

Fatal error: Declaration of Bpost\BpostApiClient\Bpost\Order\Box\At247::createFromXML(SimpleXMLElement $xml) must be compatible with Bpost\BpostApiClient\Bpost\Order\Box\National::createFromXML(SimpleXMLElement $nationalXml, $self = NULL)

kouinkouin commented 5 years ago

Sorry, I fixed it, and commit/push it some hours ago :-/ .
Thanks for the patch anyway!