Antidot-be / bpost-api-library

Other
24 stars 21 forks source link

Update psr/log dependency #23

Closed jochensengier closed 5 years ago

kouinkouin commented 5 years ago

https://getcomposer.org/doc/articles/versions.md#caret-version-range-

^1.0 includes ^1.1. Am I wrong?

Then, commit the file composer.lock

jochensengier commented 5 years ago

No, you're not wrong. Mea culpa!

However, when I try to install the library in a project where psr/log 1.1.0 is required, I get the following error:

antidot-be/bpost-api-library 3.4.0 requires psr/log ~1.0.0 -> satisfiable by psr/log[1.0.0, 1.0.1, 1.0.2].

composer require antidot-be/bpost-api-library
Using version ^3.4 for antidot-be/bpost-api-library
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Conclusion: don't install antidot-be/bpost-api-library 3.4.7
    - Conclusion: don't install antidot-be/bpost-api-library 3.4.6
    - Conclusion: don't install antidot-be/bpost-api-library 3.4.5
    - Conclusion: don't install antidot-be/bpost-api-library 3.4.3
    - Conclusion: remove psr/log 1.1.0
    - Installation request for antidot-be/bpost-api-library ^3.4 -> satisfiable by antidot-be/bpost-api-library[3.4.0, 3.4.3, 3.4.5, 3.4.6, 3.4.7].
    - Conclusion: don't install psr/log 1.1.0
    - antidot-be/bpost-api-library 3.4.0 requires psr/log ~1.0.0 -> satisfiable by psr/log[1.0.0, 1.0.1, 1.0.2].
    - Can only install one of: psr/log[1.0.0, 1.1.0].
    - Can only install one of: psr/log[1.0.1, 1.1.0].
    - Can only install one of: psr/log[1.0.2, 1.1.0].
    - Installation request for psr/log (locked at 1.1.0) -> satisfiable by psr/log[1.1.0].
kouinkouin commented 5 years ago

I will try to make a composer install with the updated code (with changes of #22) on the day

jochensengier commented 5 years ago

Sorry for wasting your time, I forgot to try the master branch... Works like a charm!

"require": {
        "antidot-be/bpost-api-library": "dev-master",
},
"repositories": [
      {
            "type": "vcs",
            "url": "https://github.com/Antidot-be/bpost-api-library"
        }
    ]
}
kouinkouin commented 5 years ago

Nice :-) .

I will make a release [I don't know when] in the week, run a composer update the next Monday to be sure.

jochensengier commented 5 years ago

Awesome, thanks!!!

kouinkouin commented 5 years ago

https://packagist.org/packages/antidot-be/bpost-api-library#3.4.8