search

Antidot-be / bpost-api-library

Other
24 stars 19 forks source link

PHP 8: Fixed string/int comparison in ApiCaller #28

Closed JeroenVanOort closed 3 years ago

JeroenVanOort commented 3 years ago

I ran into a problem while running this package in PHP 8; because the output of curl_errno was compared with a string, all requests would result in a BpostCurlException. As far as I know, the return type of curl_errno has always been an integer, so this should be backwards compatible.

This seems to be the only fixed required to get it running in PHP 8.

stijnster commented 3 years ago

Seems like a duplicate from my pull request #29 :)

stijnster commented 3 years ago

Awesome, can you bump the version number as well, so we can refer to that from our composer.json file?

kouinkouin commented 3 years ago

Oh sure! I will do it in the week (sorry to don't do it before :-/ )

stijnster commented 3 years ago

Hi there, I hope you are well.

Just a quick reminder; can you bump the version number so we can refer to the latest version from our composer.json file.

Thanks!

kouinkouin commented 3 years ago

Oh... I am sorry... I forgot you :-( . The release has just been deployed (3.4.9).

Thanks for the reminder!

stijnster commented 3 years ago

Awesome, thanks!