Closed sirnacnud closed 8 years ago
Yeah, LNNNotificationsUI would look much better than current implementation.
Also, there's BRYXBanner as alternative
@sirnacnud this is a good idea. You can look at it if you like and submit a pull request.
NotificationCoordinator
is responsible for showing notifications, basically you would have to change showNextNotification
method. Also current notification implementation can be removed from NotificationWindow
.
LNNotificationsUI can be integrated via CocoaPods.
Created PR #206
Done
I have been testing Antidote through testflight. I feel the In-App Notifications appearance and behavior could be improved to resemble the look and behavior of the iOS notification banners. The current In-App Notifications are fairly short and animate off the screen by sliding down.
In my own apps, I have used LNNotificationsUI for In-App Notifications, as it provides the same look and behavior as the iOS notification banners. If you are open to this change, I can investigate using
LNNotificationsUI
in Antidote and can submit a PR.