Closed Chuongv closed 9 years ago
So, you are planning to store call duration in OCTMessageCall?
I was thinking about implementing call duration not with startDate, but with timer:
This way if application will be killed (or will crash :open_mouth:) call duration will be still correct.
Let me know what you think..If the above sounds good, I can start removing OCTDBCall.
This looks good and indeed there is no need in OCTDBCall.
That sounds like a good idea! I think using something like NSTimer would help with adding seconds to call duration? Anyways, I'll remove my current implementation and create another PR when it's ready
I'm not sure where you will run NSTimer, it is not that easy to do on background thread. You can also take a look at GCD timer.
Okay then.
Halfway through I realized that we could implement
OCTSubmanagerCalls
without the use ofOCTDBCall
. What's important however, is that we need to capture the call duration throughOCTMessageAbstract
, which hasn't been implemented yet.Let me know what you think..If the above sounds good, I can start removing
OCTDBCall
.Thanks