Antidote-for-Tox / objcTox

No longer maintained
Mozilla Public License 2.0
38 stars 12 forks source link

Revamp of OCTCall and start implementation of OCTToxAV into Submanager #32

Closed Chuongv closed 9 years ago

Chuongv commented 9 years ago

Halfway through I realized that we could implement OCTSubmanagerCalls without the use of OCTDBCall. What's important however, is that we need to capture the call duration through OCTMessageAbstract, which hasn't been implemented yet.

Let me know what you think..If the above sounds good, I can start removing OCTDBCall.

Thanks

dvor commented 9 years ago

So, you are planning to store call duration in OCTMessageCall?

I was thinking about implementing call duration not with startDate, but with timer:

This way if application will be killed (or will crash :open_mouth:) call duration will be still correct.

dvor commented 9 years ago

Let me know what you think..If the above sounds good, I can start removing OCTDBCall.

This looks good and indeed there is no need in OCTDBCall.

Chuongv commented 9 years ago

That sounds like a good idea! I think using something like NSTimer would help with adding seconds to call duration? Anyways, I'll remove my current implementation and create another PR when it's ready

dvor commented 9 years ago

I'm not sure where you will run NSTimer, it is not that easy to do on background thread. You can also take a look at GCD timer.

dvor commented 9 years ago

Okay then.