search

Antidote-for-Tox / objcTox

No longer maintained
Mozilla Public License 2.0
37 stars 12 forks source link

Improve call handling #43

Closed Chuongv closed 9 years ago

Chuongv commented 9 years ago

Builds on top of #42 . Feel free to close the other if you want to review both at the same time.

This PR improves the call handling. You can call -> end call then call again without having to restart the app.

Muting the microphone is controlled by a property. Unfortunately the old method did not allow us to mute the scope once the audio unit is initialized.

dvor commented 9 years ago

Github doesn't update pull request when my branch updates. Can you do that?

Chuongv commented 9 years ago

Done :+1:

Chuongv commented 9 years ago

Just fixed the updateOutput

Chuongv commented 9 years ago

Done, pushed up the changes. Let me know if I missed anything. Not sure if I did the dispatch_once correctly, so if you could please review :smile:

Thanks!

Chuongv commented 9 years ago

@dvor done