search

AntiqueAtlasTeam / AntiqueAtlas

A Minecraft mod that adds a fancy interactive map item.
http://www.minecraftforum.net/topic/2045745-164forge-antique-atlas
Other
252 stars 72 forks source link

Render viewing the atlas in third-person #326

Open Lucipo opened 3 years ago

Lucipo commented 3 years ago

Describe the bug When looking at a held atlas, a third-person render is not shown. This is more of a suggestion because some mods like a first/third-person mod or other players in multiplayer want/need this feature.
(https://www.curseforge.com/minecraft/mc-mods/first-person-model) OR compatibility with a third-person animation with https://www.curseforge.com/minecraft/mc-mods/not-enough-animations installed would also be a good option since it also adds third-person map animations already. To Reproduce Hold an atlas Go in third person It only renders the item :(

On Fabric, all latest versions always

Additional context This is a lot more of a suggestion than a bug report but I think this will fit nicely with other mods that one may have in a modpack or for a little bit fancier gameplay with friends or in third-person.

And it could always be a config option on/off by default.

tr7zw commented 3 years ago

I'm the developer of the First person mod/Not enough animations, so a small bump to this issue since I get asked a lot to add third-person animations for antique atlas, but at least in my opinion this should be done by the mod itself.

tyra314 commented 3 years ago

Tbh. I'd gladly accept a PR, but I have more pressing things to work on.

tr7zw commented 3 years ago

https://github.com/AntiqueAtlasTeam/AntiqueAtlas/blob/b8ac09c5f739e6055108f823e76bcfa0d2d478c9/src/main/java/hunternif/mc/impl/atlas/mixin/HeldItemRendererMixin.java Probably only will need some modifications (from?) here. I'll take a look at it when I have time.

tr7zw commented 3 years ago

Got around to look into it. grafik Still needs some tweaking with orientations and the big version when holding it with two hands still looks really janky. Also, it would require to lock this behind having Not enough animations installed(or copy mixins/logic with the arm transforms into this mod). One last issue: The textures are rendered with the Text RenderLayer which has culling active, causing the entire thing to be invisible from behind. For the vanilla maps I used access wideners and created a No Cull Text RenderLayer, not sure how to handle this here.

codemaster101-web commented 1 year ago

Is this still being looked into?

tr7zw commented 1 year ago

My pr is open since 2021 🤷