search

AntoineGa / Seq.App.Teams

Seq application for Microsoft Teams
MIT License
13 stars 10 forks source link

Cross-platform/.NET Standard 2.0 support #17

Closed nblumhardt closed 2 years ago

nblumhardt commented 2 years ago

Fixes #14.

Bumps the major version to 2.0, though I'm not sure whether the older package supports any earlier Seq versions than this one will. Seems reasonable to signal through the version number that some substantial changes have taken place.

Happy to tweak in any way you think necessary - please just let me know :-)

Installs locally:

image

I don't have a Teams instance, so testing this with a bogus webhook URL, but seems to be happy:

image

Note that the package icon won't necessarily show correctly on 2021.2 and earlier Seq instances; 2021.3 adds support for embedded package icons, which NuGet now seems to require.

xantari commented 2 years ago

This is awesome! Thanks @nblumhardt

AntoineGa commented 2 years ago

That's interesting you are not using Cake or Fake to build

nblumhardt commented 2 years ago

Thanks for taking a look! 😎

RE Cake/Fake, we've been using a somewhat Cake-like system to build Seq (lots of moving parts!) but for standalone libraries I'm finding that the dotnet (+ MSBuild) tooling is good enough now to not need much more scripting on top. Is probably time I did check out Cake again, though! 👍