Closed nblumhardt closed 2 years ago
I was looking at updating the Teams app to include AdaptiveCards, but, uh .. yeah, not fabulous after my initial pass. The adaptive cards story is a bit of a mess tbh. Will be awesome to see the 2021.3 update take shape here - we use it a lot.
it looks good to me. Why are we removing ForContext in log though ?
ok, re-reading, it's fine. It takes some times to get the GetProperty loop, just by reading it
Since there's quite a bit more information we can add to the 2021.3 alerts, to keep the size of the PR manageable and to make things reviewable, I thought I'd send this checkpoint PR first
This PR:
OnAttached()
hookRun.ps1
, which will useseqcli
(if installed) to run the app outside of Seq (avoiding packaging/app installation etc. for debugging 🎉 )There's one small functional change: the code only includes the (potentially sensitive?) Teams webhook URL in diagnostic events when the
TraceMessage
flag is enabled, and adds a warning about this to the help text for that property. My reasoning is that it's not otherwise apparent that the webhook URL will end up in Seq events when errors occur (thoughts?).Still works as before, on my local instance:
I tried to follow the project's style/conventions as much as possible, but I'm not 100% sure of the intention in all places, so if there's anything you'd like tweaked or reverted no matter how trivial, as always, please just let me know :-)