AntoineGa / Seq.App.Teams

Seq application for Microsoft Teams
MIT License
13 stars 10 forks source link

Initial support for 2021.3 Alerts, some housekeeping #19

Closed nblumhardt closed 2 years ago

nblumhardt commented 2 years ago

Since there's quite a bit more information we can add to the 2021.3 alerts, to keep the size of the PR manageable and to make things reviewable, I thought I'd send this checkpoint PR first

This PR:

There's one small functional change: the code only includes the (potentially sensitive?) Teams webhook URL in diagnostic events when the TraceMessage flag is enabled, and adds a warning about this to the help text for that property. My reasoning is that it's not otherwise apparent that the webhook URL will end up in Seq events when errors occur (thoughts?).

Still works as before, on my local instance:

Seq event shown in Teams

I tried to follow the project's style/conventions as much as possible, but I'm not 100% sure of the intention in all places, so if there's anything you'd like tweaked or reverted no matter how trivial, as always, please just let me know :-)

MattMofDoom commented 2 years ago

I was looking at updating the Teams app to include AdaptiveCards, but, uh .. yeah, not fabulous after my initial pass. The adaptive cards story is a bit of a mess tbh. Will be awesome to see the 2021.3 update take shape here - we use it a lot.

AntoineGa commented 2 years ago

it looks good to me. Why are we removing ForContext in log though ?

AntoineGa commented 2 years ago

ok, re-reading, it's fine. It takes some times to get the GetProperty loop, just by reading it