search

AntoineGa / Seq.App.Teams

Seq application for Microsoft Teams
MIT License
13 stars 10 forks source link

Improving property serialization and configuration #35

Closed TheNr1Guest closed 2 years ago

TheNr1Guest commented 2 years ago

I changed the processing of properties to always be recursive in the case of nested dictionaries. Passing down configuration allowed me to parse certain properties as JSON while by default adding them to the card instead of the output of ToString on a dictionary.

I changed the ExcludeProperties boolean to a ExcludedProperties string list so there can be a more finer control of which properties to exclude. While allowing to the previous behavior with a special property name All to indicate all Seq properties should be ignored.

Unit tests have been expanded, only when manually trying to test the code I ran into some problems. Running Run.ps1 with the correct webhook parameter did nothing. I get no output. seq tail --json does give me output so there is either something going wrong with piping the events or there is actually something going wrong in the app, only I get no output. So help in that area is needed.

This should technically resolve https://github.com/AntoineGa/Seq.App.Teams/issues/32 without having to configure any properties to be serialized as JSON.

AntoineGa commented 2 years ago

Looks good to me !

Thanks for contributing