search

AntoineRichard / OmniLRS

SpaceR and SRL Lunar simulation
Other
54 stars 16 forks source link

fixed broken ros1 wrappers for the largescale environment #41

Open TedVanderfeen opened 2 weeks ago

TedVanderfeen commented 2 weeks ago

Hey Antoine,

I needed ROS1 for some custom nodes and I noticed that it wouldn't launch the large_scale environment because it didn't have some checks that were implemented in the ROS2 wrappers and also a typo that was making it revert to the base wrapper which returned a NotImplementedError.

Largescale working in Ros1 again (with removing Humble sourcing from the entrypoint and manually sourcing the Isaac included noetic setup.bash)

Thanks!