search

AntonEmery / chord-app

React app for notating guitar chords
2 stars 1 forks source link

Cooking not being sent to client when running app locally #92

Open AntonEmery opened 4 years ago

AntonEmery commented 4 years ago

After our work last night cookie is no longer being sent to the client when I login. I don't see it in the response or in the application tab in cookies in Chrome.

This is still in my local branch, I have not pushed it up.

This line seems to be the issue. https://github.com/AntonEmery/chord-app/blob/da7ee9b54aa514e4dda200b9bce19b6778ee613c/src/server/app.js#L36

If I change it to this it works fine, but then it obviously won't work in prod. cookie: { secure: false, httpOnly: false, maxAge: 600000000 }

I thought this was already working before, but then last night I had to reinstall all my Node Modules, maybe that broke something.

Not sure how to handle this, maybe we need different cookie properties for local and production.

@XiXiaPdx Can you try running the app locally with the code you currently have and see if it works?

AntonEmery commented 4 years ago

I was messing around with this some more, and I was mistaken when we had this working previously on local after we set the domain value on the cookie. It needs to be different when we run the app locally since the front end domain is obviously not chord-app.com, so the browser won't store the cookie