Type checks when calculating with point at infinity

AntonKueltz / fastecdsa

Python library for fast elliptic curve crypto

https://pypi.python.org/pypi/fastecdsa

The Unlicense

263 stars 76 forks source link

Type checks when calculating with point at infinity #50

Closed jannikluhn closed 4 years ago

jannikluhn commented 4 years ago

At the moment, there are cases in which calculating with the point at infinity gives unexpected results and others in which an AttributeError is raised:

Point.IDENTITY_ELEMENT + 2 gives 2
Point.IDENTITY_ELEMENT - 2 raises an AttributeError
Point.IDENTITY_ELEMENT * 1.5 raises an AttributeError

In all of these cases I would expect an TypeError.

AntonKueltz commented 4 years ago

Good catch. Fixed in 3fef4b1753fa23afb7d7008897aac7b9bb995479, released in v2.1.0.