search

AntonLydike / riscemu

RISC-V emulator in python
MIT License
48 stars 14 forks source link

Using '#' for comments #3

Closed tobiasgrosser closed 2 years ago

tobiasgrosser commented 2 years ago

The RISCV manual at https://github.com/riscv/riscv-isa-manual uses '#' to mark single-line comments. However, it seems riscemu uses ';'. This is inconsistent and I would expect riscemu to use '#' instead.

AntonLydike commented 2 years ago

The Assembly parser will probably be reworked completely in the coming weeks/months to be more spec compliant. The old parser has quite a few weaknesses.

tobiasgrosser commented 2 years ago

I am currently working on an assembly parser for RISC-V. Also not perfect, but happy to collaborate if you are interested.

AntonLydike commented 2 years ago

Maybe you can keep an eye on #5, I've already implemented a new, much simpler tokenizer (and wrote some tests for it).

AntonLydike commented 2 years ago

I think the PR is now in a relatively stable state. I'd be more than happy to get your feedback on the changes.

AntonLydike commented 2 years ago

This is now finally fixed with the merge of #5