AntonShuvaev / elasticsearch4idea

Elasticsearch Plugin for JetBrains IDEs
https://plugins.jetbrains.com/plugin/14512-elasticsearch
59 stars 8 forks source link

Store request history and connection details separately #116

Closed msmuenchen closed 1 year ago

msmuenchen commented 1 year ago

Is your feature request related to a problem?

Currently, the settings file .idea/elasticsearchSettings.xml contains the cluster configuration (<option name="clusterConfigurations">) and the request history (<option name="requestHistory">) in the same file.

This can be a concern both for commit-churn (i.e. if you use the request feature, the history pollutes the git status), and subsequently for privacy issues (e.g. you connect to a production cluster and search for PII, and then accidentally do a git commit -a).

Describe the solution you'd like

The cluster configurations should each be stored in a separate file (similar to the SQL data sources or run configurations, which are in their own directory), and the history in a separate file as well.

That way, one can decide which configuration(s) to commit, and which to add to a .gitignore (ideally, the plugin would add a .gitignore by default in the folder, including the history file).

Additional context

No response

AntonShuvaev commented 1 year ago

Thanks for the suggestion. I'll do it in the next version.

AntonShuvaev commented 1 year ago

Implemented in 2023.2.4