Antonboom / testifylint

The Golang linter that checks usage of github.com/stretchr/testify.
https://github.com/stretchr/testify
MIT License
101 stars 8 forks source link

useless-assert: add Zero and Empty to detected pattern #107

Closed ccoVeille closed 5 months ago

ccoVeille commented 5 months ago

Fixes #105

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9398780801

Details


Totals Coverage Status
Change from base Build 9379444402: 0.0%
Covered Lines: 2025
Relevant Lines: 2159

💛 - Coveralls
Antonboom commented 5 months ago

I've never seen these somebody use bool operations in these assertions

does this really make sense?

ccoVeille commented 5 months ago

I would say it will catch almost nothing, but why not merging it. It costs nothing to maintain.

Your code keeps evolving and new cases might be added to useless-assert, one added later may catch code using Zero and Empty