compares: add Empty And Zero

Antonboom / testifylint

The Golang linter that checks usage of github.com/stretchr/testify.

https://github.com/stretchr/testify

MIT License

101 stars 8 forks source link

Closed ccoVeille closed 5 months ago

ccoVeille commented 5 months ago

Some people may use testify Zero, Empty, NotZero, and NotEmpty asserters the same way True or False could have been used

Antonboom commented 5 months ago

Hi!

Any real examples please, looks like something weird. I do not want to promote the very strange use of testify, even in tests.

ccoVeille commented 5 months ago

I failed to find real life example…

Should I nuke #111 completly ? or could we keep the refactoring commits I made ?

Antonboom commented 5 months ago

or could we keep the refactoring commits I made ?

Yes, please, open new PR with refactored part if this change makes sense Thanks