bool compare: add Zero and Empty - Githubissues

Antonboom / testifylint

The Golang linter that checks usage of github.com/stretchr/testify.

https://github.com/stretchr/testify

MIT License

101 stars 8 forks source link

bool compare: add Zero and Empty #116

Closed ccoVeille closed 5 months ago

ccoVeille commented 5 months ago

2 blocks of commits:

Refactoring to prepare the next block
- gen: move assertion sorter to a function so it could be reused
- bool_compare: use variables in generator
- bool_compare: use predicting order for tests
- bool_compare: refactor tests to easily add use cases
Add zero and empty detection to bool-compare Fixes https://github.com/Antonboom/testifylint/issues/106

ccoVeille commented 5 months ago

I can split the PR into 2-3 PRs if you prefer

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9417715414

Details

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.793%

Totals
Change from base Build 9379444402:	0.0%
Covered Lines:	2025
Relevant Lines:	2159

💛 - Coveralls

ccoVeille commented 5 months ago

@Antonboom I closed

https://github.com/Antonboom/testifylint/issues/106

So closing this PR would be logic.

But I made refactoring in the tests that I think that could be interesting to keep.

So everything except the last commit.

Would you agree me to open another PR about the refactoring only?

ccoVeille commented 5 months ago

https://github.com/Antonboom/testifylint/pull/121#issuecomment-2166625063

was opened, let's close this one