search

Antonboom / testifylint

The Golang linter that checks usage of github.com/stretchr/testify.
https://github.com/stretchr/testify
MIT License
87 stars 8 forks source link

NEW CHECKERS IN PRIORITY #143

Open Antonboom opened 1 week ago

Antonboom commented 1 week ago

Hi, everyone!

I appreciate your contribution to testifylint, but at the moment the project has not yet entered the stabilization phase, but is maintaining a strategy for unrealized functionality.

Thus, we should concentrate on the implementation of new checkers, and not on multi-day discussions about whether Empty is suitable for typed zero or not (relatively speaking).

After the minor release, we can waste some time (e.g. not more than two) to other issues (related to old checkers). And to begin to focus on the next milestone: https://github.com/Antonboom/testifylint/milestones

Checkers can be implemented in any order, the milestones above are my vision of priorities. If some checkers implementation are awaiting my feedback, that feel free to ping me.

Thank you!

Antonboom commented 1 week ago

(cc) @ccoVeille @mmorel-35

ccoVeille commented 1 week ago

OK, noted.

I'm sorry if my remarks leads to noise and distraction.

I was focused on empty because it was making sense for me, and my codebase.

Also, I was looking at these kind of issues because it's easier to contribute by updating/changing an existing linter than creating a new one.

But, I now understand better what you expect. It's a good thing to have a clear roadmap.

ccoVeille commented 1 week ago

One thing that also leads me to create issue is because it's the only way for me to communicate with you.

I think it would be better if we could have another way to discuss and talk about things.

Here are the option I'm thinking about:

What do you think about it?

Antonboom commented 1 week ago

enable discussions on project

I thought about it too. Done 👌

mmorel-35 commented 1 week ago

Hi @ccoVeille , Please send me an invite to join https://gophers.slack.com/ I'm not a member yet.

ccoVeille commented 1 week ago

It said unable to send invite. I will have to check, and maybe contact the admin of this community

ccoVeille commented 1 week ago

@mmorel-35 please try this

https://join.slack.com/t/gophers/shared_invite/zt-2lmem2ic2-EfbtKK9FGlBHHgeEu0an7Q

The link is valid a month