search

Antonboom / testifylint

The Golang linter that checks usage of github.com/stretchr/testify.
https://github.com/stretchr/testify
MIT License
101 stars 8 forks source link

new checker `http-const` #155

Closed mmorel-35 closed 3 weeks ago

mmorel-35 commented 5 months ago

Closes #141

mmorel-35 commented 5 months ago

This probably deserves a bit of refactoring. This is based on https://github.com/sashamelentyev/usestdlibvars work.

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9659794485

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/http_const.go 70 71 98.59%
<!-- Total: 78 79 98.73% -->
Totals Coverage Status
Change from base Build 9608177733: 0.2%
Covered Lines: 2247
Relevant Lines: 2395
💛 - Coveralls
coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9668183301

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/http_const.go 61 62 98.39%
<!-- Total: 69 70 98.57% -->
Totals Coverage Status
Change from base Build 9608177733: 0.1%
Covered Lines: 2238
Relevant Lines: 2386
💛 - Coveralls
coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9668248204

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/http_const.go 63 68 92.65%
<!-- Total: 71 76 93.42% -->
Totals Coverage Status
Change from base Build 9608177733: -0.02%
Covered Lines: 2240
Relevant Lines: 2392
💛 - Coveralls
coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9668312351

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/http_const.go 63 68 92.65%
<!-- Total: 71 76 93.42% -->
Totals Coverage Status
Change from base Build 9608177733: -0.02%
Covered Lines: 2240
Relevant Lines: 2392
💛 - Coveralls
coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9668623785

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/http_const.go 63 68 92.65%
<!-- Total: 71 76 93.42% -->
Totals Coverage Status
Change from base Build 9608177733: -0.02%
Covered Lines: 2240
Relevant Lines: 2392
💛 - Coveralls
coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9669768290

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/http_const.go 69 76 90.79%
<!-- Total: 77 84 91.67% -->
Totals Coverage Status
Change from base Build 9608177733: -0.08%
Covered Lines: 2246
Relevant Lines: 2400
💛 - Coveralls
coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9669932292

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/http_const.go 72 76 94.74%
<!-- Total: 80 84 95.24% -->
Totals Coverage Status
Change from base Build 9608177733: 0.04%
Covered Lines: 2249
Relevant Lines: 2400
💛 - Coveralls
coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9669999628

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/http_const.go 72 76 94.74%
<!-- Total: 80 84 95.24% -->
Totals Coverage Status
Change from base Build 9608177733: 0.04%
Covered Lines: 2249
Relevant Lines: 2400
💛 - Coveralls
coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9670110548

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/http_const.go 72 76 94.74%
<!-- Total: 80 84 95.24% -->
Totals Coverage Status
Change from base Build 9608177733: 0.04%
Covered Lines: 2249
Relevant Lines: 2400
💛 - Coveralls
coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9673263571

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/http_const.go 72 76 94.74%
<!-- Total: 80 84 95.24% -->
Totals Coverage Status
Change from base Build 9673069496: 0.04%
Covered Lines: 2289
Relevant Lines: 2442
💛 - Coveralls
ccoVeille commented 5 months ago

I now understand why @ldez (hi :wave:) expects PR to do not rewriting history during code review.

It's something I have been doing for a while, even in this project. But now I'm facing the way @mmorel-35 does, which I would have done too, I can see how difficult it is yo track the changes made between each iterations.

Here there is only one commit, and I have to read everything again and again instead of seeing the small changes made by each reviews

I repeat it's something I have done many times, even recently, so I don't blame you @mmorel-35, but now I understand Ludovic's guidance

ccoVeille commented 5 months ago

@mmorel-35 I have no idea what you changed with your last commit. I reviewed everything and spotted things I found. But I have no idea if it's new code or not.

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9674262358

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/http_const.go 72 80 90.0%
<!-- Total: 80 88 90.91% -->
Totals Coverage Status
Change from base Build 9673069496: -0.1%
Covered Lines: 2289
Relevant Lines: 2446
💛 - Coveralls
coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9674319119

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/http_const.go 75 83 90.36%
<!-- Total: 83 91 91.21% -->
Totals Coverage Status
Change from base Build 9673069496: -0.1%
Covered Lines: 2292
Relevant Lines: 2449
💛 - Coveralls
coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9674373889

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/http_const.go 75 83 90.36%
<!-- Total: 83 91 91.21% -->
Totals Coverage Status
Change from base Build 9673069496: -0.1%
Covered Lines: 2292
Relevant Lines: 2449
💛 - Coveralls
coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9674389614

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/http_const.go 75 83 90.36%
<!-- Total: 83 91 91.21% -->
Totals Coverage Status
Change from base Build 9673069496: -0.1%
Covered Lines: 2292
Relevant Lines: 2449
💛 - Coveralls
mmorel-35 commented 5 months ago

@ccoVeille , I won’t squash my commit but please @Antonboom , remove the "update my_file.go" from the content of the squashed commit of the pull-request. It makes my eyes bleed are totally useless comments.

ccoVeille commented 5 months ago

Thanks for taking my workflow suggestion into account.

I do hate to see a log like that. But for reviewing it's way simpler.

Please note, I'm OK with you to rearrange the commits in the way you intend. But many only once you get an approval for the PR. Anx with a message like in the PR like "squashing previously reviewd changes"

I dislike squashed PR too, that's why I'm suggesting that.

Also squashing when merging would nuke the respective contribution of each developer. Think about Anton "maintainer review" commit.

At least, GitHub doesn't nuke authors who contributed as it adds the Co-Authored-By tag in the squashed commit message.

But I do think it's way easier for reviewing with atomic and iterative commits.

Thanks again for baring with me

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9675720558

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/http_const.go 75 83 90.36%
<!-- Total: 83 91 91.21% -->
Totals Coverage Status
Change from base Build 9673069496: -0.1%
Covered Lines: 2292
Relevant Lines: 2449
💛 - Coveralls
mmorel-35 commented 5 months ago

@ccoVeille , @Antonboom , I won't be able to use a terminal in the next 10 days so if you want to take over this work frrom here, please feel free to do it .

ccoVeille commented 5 months ago

Sute, thanks for letting us know.

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9695506618

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/http_const.go 72 80 90.0%
<!-- Total: 80 88 90.91% -->
Totals Coverage Status
Change from base Build 9673069496: -0.1%
Covered Lines: 2289
Relevant Lines: 2446
💛 - Coveralls
coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9696894260

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/http_const.go 73 85 85.88%
<!-- Total: 81 93 87.1% -->
Totals Coverage Status
Change from base Build 9673069496: -0.3%
Covered Lines: 2290
Relevant Lines: 2451
💛 - Coveralls
coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9702352952

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/http_const.go 77 85 90.59%
<!-- Total: 85 93 91.4% -->
Totals Coverage Status
Change from base Build 9673069496: -0.1%
Covered Lines: 2294
Relevant Lines: 2451
💛 - Coveralls
coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9723300042

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/http_const.go 77 85 90.59%
<!-- Total: 85 93 91.4% -->
Totals Coverage Status
Change from base Build 9673069496: -0.1%
Covered Lines: 2294
Relevant Lines: 2451
💛 - Coveralls
coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9723821079

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/helpers_basic_type.go 12 14 85.71%
internal/checkers/http_const.go 64 70 91.43%
<!-- Total: 87 95 91.58% -->
Totals Coverage Status
Change from base Build 9673069496: -0.1%
Covered Lines: 2289
Relevant Lines: 2446
💛 - Coveralls
coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9726718535

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/helpers_basic_type.go 12 14 85.71%
internal/checkers/http_const.go 64 70 91.43%
<!-- Total: 87 95 91.58% -->
Totals Coverage Status
Change from base Build 9673069496: -0.1%
Covered Lines: 2289
Relevant Lines: 2446
💛 - Coveralls
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9798875390

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/helpers_basic_type.go 12 14 85.71%
internal/checkers/http_const.go 64 70 91.43%
<!-- Total: 87 95 91.58% -->
Totals Coverage Status
Change from base Build 9743211634: -0.1%
Covered Lines: 2289
Relevant Lines: 2446
💛 - Coveralls
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9799153037

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/helpers_basic_type.go 12 14 85.71%
internal/checkers/http_const.go 64 70 91.43%
<!-- Total: 87 95 91.58% -->
Totals Coverage Status
Change from base Build 9743211634: -0.1%
Covered Lines: 2289
Relevant Lines: 2446
💛 - Coveralls
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9826249234

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/helpers_basic_type.go 12 14 85.71%
internal/checkers/http_const.go 64 70 91.43%
<!-- Total: 87 95 91.58% -->
Totals Coverage Status
Change from base Build 9743211634: -0.1%
Covered Lines: 2289
Relevant Lines: 2446
💛 - Coveralls
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9826249234

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/helpers_basic_type.go 12 14 85.71%
internal/checkers/http_const.go 64 70 91.43%
<!-- Total: 87 95 91.58% -->
Totals Coverage Status
Change from base Build 9743211634: -0.1%
Covered Lines: 2289
Relevant Lines: 2446
💛 - Coveralls
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9826249234

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/helpers_basic_type.go 12 14 85.71%
internal/checkers/http_const.go 64 70 91.43%
<!-- Total: 87 95 91.58% -->
Totals Coverage Status
Change from base Build 9743211634: -0.1%
Covered Lines: 2289
Relevant Lines: 2446
💛 - Coveralls
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9826674310

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/helpers_basic_type.go 12 14 85.71%
internal/checkers/http_const.go 64 70 91.43%
<!-- Total: 87 95 91.58% -->
Totals Coverage Status
Change from base Build 9743211634: -0.1%
Covered Lines: 2289
Relevant Lines: 2446
💛 - Coveralls
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9826674310

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/helpers_basic_type.go 12 14 85.71%
internal/checkers/http_const.go 64 70 91.43%
<!-- Total: 87 95 91.58% -->
Totals Coverage Status
Change from base Build 9743211634: -0.1%
Covered Lines: 2289
Relevant Lines: 2446
💛 - Coveralls
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9826674310

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/helpers_basic_type.go 12 14 85.71%
internal/checkers/http_const.go 64 70 91.43%
<!-- Total: 87 95 91.58% -->
Totals Coverage Status
Change from base Build 9743211634: -0.1%
Covered Lines: 2289
Relevant Lines: 2446
💛 - Coveralls
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 10704164578

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/helpers_basic_type.go 12 14 85.71%
internal/checkers/http_const.go 64 70 91.43%
<!-- Total: 87 95 91.58% -->
Totals Coverage Status
Change from base Build 10661004539: -0.1%
Covered Lines: 2288
Relevant Lines: 2445
💛 - Coveralls