enable several rules from revive - Githubissues

Antonboom / testifylint

The Golang linter that checks usage of github.com/stretchr/testify.

https://github.com/stretchr/testify

MIT License

101 stars 8 forks source link

enable several rules from revive #164

Closed mmorel-35 closed 2 months ago

mmorel-35 commented 4 months ago

Closes #158

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9798828212

Details

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.003%) to 93.689%

Totals
Change from base Build 9743211634:	-0.003%
Covered Lines:	2212
Relevant Lines:	2361

💛 - Coveralls

ccoVeille commented 4 months ago

We might need to enable more, but this one is great. I didn't have a chance to keep working on https://github.com/ccoVeille/golangci-lint-config-examples

I think we could also enable

empty-block
if-return
identical-branch
indent-error-flow
superfluous-else
unreachable-code
useless-break

All these are safe and works perfectly with early-return

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9799145161

Details

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.003%) to 93.689%

Totals
Change from base Build 9743211634:	-0.003%
Covered Lines:	2212
Relevant Lines:	2361

💛 - Coveralls

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9799180994

Details

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.003%) to 93.689%

Totals
Change from base Build 9743211634:	-0.003%
Covered Lines:	2212
Relevant Lines:	2361

💛 - Coveralls

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9826233598

Details

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.003%) to 93.689%

Totals
Change from base Build 9743211634:	-0.003%
Covered Lines:	2212
Relevant Lines:	2361

💛 - Coveralls

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10609022856

Details

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.003%) to 93.689%

Totals
Change from base Build 10608990804:	-0.003%
Covered Lines:	2212
Relevant Lines:	2361

💛 - Coveralls