search

Antondomashnev / FBSnapshotsViewer

A mac os application that shows the failing snapshot tests from FBSnapshotTestCase
MIT License
224 stars 15 forks source link

Doesn't work for Xcode-beta #51

Closed BohdanOrlov closed 7 years ago

BohdanOrlov commented 7 years ago

Hey!

The app fails silently, nothing happens when I have failed a test in Xcode-beta-4.

I tried specifying the path to derived data explicitly (and restarting the app for the change to take effect) but it didn't help.

I see logs in derived data: image

Log command looks like this: ksdiff "/Users/bohdanorlov/Projects/Project/SnapshotTests/FailureDiffs/Tests.OwnProfileInstagramFeedViewTest/reference_testInstagramFeedView_NotConnectedAndEmpty@2x.png" "/Users/bohdanorlov/Projects/Project/SnapshotTests/FailureDiffs/Tests.OwnProfileInstagramFeedViewTest/failed_testInstagramFeedView_NotConnectedAndEmpty@2x.png"

Let me know if I can provide additional data which can help. Thank you.

Antondomashnev commented 7 years ago

Thanks for the report @BohdanOrlov 👍. I think it may be related to #50. I will try to go deeper into the problem.

Antondomashnev commented 7 years ago

Got the bug. Seems like the Xcode 9 has different location for test's log file. It was changed from Logs/Test/*.log -> Logs/Test/Diagnostics/AnotherFolder/*.log.

BohdanOrlov commented 7 years ago

Nice! I assume both folders have to be checked. Do you plan to fix this?

Antondomashnev commented 7 years ago

@BohdanOrlov yep, PR is ready. I'll fix another small issue and prepare a release.

Antondomashnev commented 7 years ago

@BohdanOrlov release 0.6.1 is out 🚀

BohdanOrlov commented 7 years ago

@Antondomashnev Works like a charm! Many thanks.

P.S. The swap button is a great idea ;)

Antondomashnev commented 7 years ago

P.S. The swap button is a great idea ;)

Thanks @orta for the original idea 😄 But keep in mind it doesn't work with Nimble-Snapshots atm #55