search

Antondomashnev / FBSnapshotsViewer

A mac os application that shows the failing snapshot tests from FBSnapshotTestCase
MIT License
224 stars 15 forks source link

Add support for FB_REFERENCE_IMAGE_DIR #61

Closed joeblau closed 7 years ago

joeblau commented 7 years ago

Our projects have snapshots in a custom directory, not in the default directory. Could you add support for checking the project's FB_REFERENCE_IMAGE_DIR for snapshot diffs?

Antondomashnev commented 7 years ago

Hey @joeblau, do you mean you have a custom IMAGE_DIFF_DIR ? Because I'm not sure how FB_REFERENCE_IMAGE_DIR can contain snapshot diffs. I'm only using it to be able to swap images.

joeblau commented 7 years ago

Yes sir. we have a custom FB_REFERENCE_IMAGE_DIR and custom IMAGE_DIFF_DIR.

Antondomashnev commented 7 years ago

I'm sorry, still not cleat what is the issue 😄 Doesn't current set up work for you?

Antondomashnev commented 7 years ago

Hey @joeblau do you mind to provide more details so I can help faster? 😄

joeblau commented 7 years ago

hey, sorry for lagging on the response. I'll explain a bit more of the details tonight.

joeblau commented 7 years ago

N/M, This is an issue with our setup.

We set the FB_REFERENCE_IMAGE_DIR in our projects post processor macros so it doesn't get included in derived data so the snapshot app doesn't pick up conflicts.

Antondomashnev commented 7 years ago

Ah, cool that it's resolved 😄