search

Antonio-Laguna / jQuery-ColorPicker

This is yet another colorpicker plugin for jQuery since most of them are not on GitHub nor being mantained at the moment.
Other
91 stars 22 forks source link

Have to click and drag to select #1

Closed benwmills closed 11 years ago

benwmills commented 12 years ago

It seems like you have to click and drag to select a color. You can't just click. Is this by design? It doesn't quite feel intuitive to me.

Antonio-Laguna commented 12 years ago

Hi @millssoftware as it's said in the readme, I just made a few changes. It suited my purpose for one thing I have to be done and since the author wasn't interested in the plugin anymore, I just created a github repo. If I have time I'll take a look and will make some improvements.

Antonio-Laguna commented 11 years ago

Ben, I've tried to reproduce this issue, could you let me know wich browser are you using?

bendman commented 11 years ago

@Belelros You probably just couldn't reproduce it because it appeared to be by design. In the original the color didn't change until the mouse was actually moved, because the event handler was bound to mousemove.

This was changed to a click event by @dm and pulled in. When using other color pickers though, the typical design is that it changes color on mousedown and on mousemove. The pull request #5 addresses this issue by making this plugin match expected behavior.

dm commented 11 years ago

Hi,

You're correct, the mousedown is more in line with other interfaces. I might actually change my fork to include that pull request.

:+1:

dm commented 11 years ago

Aaand done!

Next I think I might solve the drag selection (issue #6), just because it nags me a bit as well... :p

Antonio-Laguna commented 11 years ago

Should be fixed as of @bendman PR