search

AntonioND / nitro-engine

3D engine for the Nintendo DS
150 stars 10 forks source link

Rich text: NE_RichTextPrioritySet and NE_RichTextPriorityReset are unimplemented #28

Closed WiIIiam278 closed 5 months ago

WiIIiam278 commented 5 months ago

Attempting to call these methods will result in compiler linkage errors as they are not implemented in NERichText.c

AntonioND commented 5 months ago

Ah, that's a copy-paste error, I started to develop the code of the RichText system with a copy of the previous text system code. They need to be removed. I think it's better to ask the user to set the Z coordinate in every call.

AntonioND commented 5 months ago

There: https://github.com/AntonioND/nitro-engine/commit/48ff37231f6ae0a908b93edaea29d7037beebc8b

WiIIiam278 commented 5 months ago

Ah, that's a copy-paste error, I started to develop the code of the RichText system with a copy of the previous text system code. They need to be removed.

No problem!

I think it's better to ask the user to set the Z coordinate in every call.

Sounds reasonable — only thing is, I don't see a way of doing this at the moment? Could be missing something though :)

AntonioND commented 5 months ago

Huh, yeah, I got that wrong. Sorry, I thought the functions already took a "depth" argument. Priority functions re-introduced here: https://github.com/AntonioND/nitro-engine/commit/3f3e266a4f2fd2d68daf485d9ca84c21d06e8fd1 I don't want to break code using the functions just to add another argument.