search

AntonioND / ucity

The open-source city-building game for Game Boy Color.
429 stars 17 forks source link

Support spaces in the cloned path #3

Closed BenHetherington closed 6 years ago

BenHetherington commented 6 years ago

Apologies for intruding on your personal project, but here's a little tweak to the Makefile that I spotted when doing things with the tests in rgbds. Hope that's OK!

Before, the path to the current directory (i.e. the path to which µcity was cloned) would be included as part of each INCLUDE flag. However, this didn’t work if the path to the current directory includes spaces (e.g. within a folder called Game Boy).

To fix this, I’m simply passing -i$(dir)/ (without the current directory prefix), as it can be found within the current directory without needing to manually add the prefix.

If there was a reason for that prefix in the first place, I'm happy to be corrected!

AntonioND commented 6 years ago

Well, I've taken a look at it and I see no reason why I would need the CURDIR. I created the bulk of that makefile years ago so it was probably there because I was even worse at Makefiles than I am now (can anyone be good at makefiles, though?).