search

Antontelesh / mochawesome-merge

Merge several Mochawesome JSON reports
MIT License
85 stars 16 forks source link

Deprecated unused uuid #76

Closed jankanty closed 2 years ago

jankanty commented 2 years ago

You are using a deprecated version of uuid. But as I checked everywhere the package is no longer in use. Maybe we can remove it so it won't pop up during npm install?

Antontelesh commented 2 years ago

Hey @JanKanty, I would love to accept a PR making this change. Ideally, I would replace uuid with nanoid

jankanty commented 2 years ago

@Antontelesh I would gladly do it but I don't see any usage of this package. I even downloaded repo to search through folders but there is no require for it. If I don't see it but there is please point it to me

Antontelesh commented 2 years ago

@JanKanty can you try to remove this dependency? I don’t see it’s being used either

jankanty commented 2 years ago

@Antontelesh Do I have to update yarn.lock manually or it will update during release?

jankanty commented 2 years ago

If not I made changes here: #78

Antontelesh commented 2 years ago

I’m not sure it will, so let’s commit it as well

Antontelesh commented 2 years ago

:tada: This issue has been resolved in version 4.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Antontelesh commented 2 years ago

@JanKanty thank you for your contribution!