search

Antony-Edward-Stark / jarpy

A voice assistant that is built in python
GNU General Public License v3.0
3 stars 2 forks source link

PLEASE DO NOT PUT THE WEATHER API KEY INSIDE THE PYTHON SCRIPT #1

Closed ninja-noodle closed 1 month ago

ninja-noodle commented 1 month ago

So when I forked your jarpy project and cloned it for contribution purposes, I noticed that "your weather api key" was included in the functions.py WHICH IS TOTALLY NOT RECOMMENDED AND NOT SAFE especially if you are pushing those scripts to github where everyone can access your code freely.

The reason why it is not recommended is because It's your personal API key and you shouldn't let people to misuse it for their own **It can lead to some security vulnerabilities (eg. if your project is a very big, game-changing project, or if you are using a purchased API, people can freely use your API without your consent) and many more reasons

Here's more information about it and how you can save those api keys: Best Practices Python - Where to store API KEYS/TOKENS

So, I hope you fix that API issue as soon as possible :D

Antony-Edward-Stark commented 1 month ago

ok sir, but can you suggest me some other way?

Antony-Edward-Stark commented 1 month ago

Sir, as suggested, I've placed the API key in the file and added it in gitignore

Antony-Edward-Stark commented 1 month ago

I think the issue is solved and rectified. So, I'm closing the issue. If it was not still solved, please notify me... Thank you