Closed temporarium closed 5 years ago
@temporarium Sorry, I have omitted some code from the build. Will fix asap.
Ah, ok. Had me worried for a bit :-) Thank you for making it available!
@temporarium Fixed in latest pre-release, but still in need of rigorous testing!
Just tried with 1.0.0.22. Still the same behaviour. I even get an error/crash trying to import your sample notes.
Please try again with build 23. If it fails again please would you let me have a copy of the log file (Documents\JWLMerge\Logs). Thanks.
Well, at least it doesn't crash :-) I tried importing your notes:
[BibleKeySymbol=nwtsty]
[MepsLanguageId=0]
[1:3:15]
First Prophecy
A prophecy. A covenant. The brevity and symbolic language of the
statement left many questions unanswered!
[1:3:15:4:4:0]
Enmity
There was also enmity on the part of the woman toward the Serpent.
Satan had called into question the integrity of every one of God's
intelligent creatures, including all the angels ... they could not
do otherwise than feel a loathing toward him.
Something gets added, as seen from the screenshots:
However, it doesn't seem to be saved or written to the .jwlibrary file. Once I reopen it in JWLMerge, there is no evidence of those notes...
When I try to import mine, nothing happens.
@temporarium Thanks for feedback. I can't reproduce this - all works ok here. I will add some more logging entries
I'm getting mixed results. I was able to import a simple test file, but it doesn't work with my notes file.
Does the encoding of the text file matter? ANSI or UTF?
Are you able to import my file? Is it laid out/formatted correctly? test.txt
@temporarium Yes, I can successfully import your test.txt file. It is Ansi encoded so some of the characters are not supported (but still imports ok). Change it to UTF-8 and the characters are reproduced as they should be.
Thank you for letting me know that. So, it must be on my end... perhaps my .jwlibrary file? I would send it to you to have a look, but via a more private medium only. I'm on Windows 7x64. What else could be throwing a wrench into this?
@temporarium Please email me your backup file to the following address:
help at soundbox.on.spiceworks.com
@temporarium I've received your file and can reproduce your problem. I'll let you know as soon I have investigated. Thanks for your help.
@temporarium The problem arises when you have existing notes that refer to a highlighted section that extends over a verse boundary. I will fix.
@temporarium Please would you test the latest pre-release?
Excellent! I'm importing OK now. Thank you!
Just wondering: is there any way to tag the imported notes somehow?
Another question: is the 50-character limit for the titles set in stone, or is there a possibility you could remove it, perhaps taking every first line as note title?
Perhaps we need to take a step back and analyse requirements further. It may be that a more flexible file format (or even a common open format) for import would be better.
https://ebible.org/translation/BibleFileFormatPhilosophies.html
Wow, that's some write-up on the formats!!
I would love to see mark-up implemented in the comments, but I guess that will have to be implemented on the app itself, right?
Anyway, you know much better than I do how these notes are stored in the jwlibrary file - specifically how the tags are stored. As for importing, it could be as simple as implementing a title line for each note enclosed in {{}}, which could in addition include a comma-separated list of tags? Something like: {{First Prophecy|Prophecy,Genesis}}
I'm happy to do the testing for you :-)
Wow, that's some write-up on the formats!!
Yes. Not mine, I hasten to add. But a useful resource, and interesting reading.
Did you change/update something in 1.0.0.24?
@temporarium would you mind creating new issues for any ongoing questions / problems (i.e. one issue per question) please? It will help me not to forget items. Thanks.
So, I've tried to import some notes on Genesis and the app crashes. I limited to file to only a handful of notes (see attachment), thinking that maybe the file was too large (my Genesis notes are over 2,000 lines).
Any idea what is wrong? Are the notes too long? Do the lines have to have a line-break after x number of characters?
This is my notes file: