search

AntonyCorbett / JWLMerge

Utility to merge jwlibrary backup files
MIT License
194 stars 33 forks source link

InputField is never instantiated #34

Closed abdon-copper closed 3 years ago

abdon-copper commented 3 years ago

The class InputField is never instantiated.

To Reproduce Steps to reproduce the behavior:

  1. In Visual Studio, search for references to InputField.
  2. See that the no input fields are ever read from the database, the list will stay empty.

Expected behavior I'm not sure what the meaning is of InputField, but it should not get lost during merging. Some code like this could be added:

result.InputFields.AddRange(ReadAllRows(connection, ReadInputField));

Version Git ref 2644a343e2f1b0326616e683bdb64d0cd6e4c9a4

Thanks for this useful project!

AntonyCorbett commented 3 years ago

@abdon-copper Thanks. I did consider this when it was introduced in the most recent DB update (v8). However, AFAIK, it is unused in the current schema. Unless we can understand the semantics of the InputField table I can't see how to properly merge the data. Reading the data from the database as you describe would certainly be the first step when we know more about it.

abdon-copper commented 3 years ago

Hello, the InputField table is now used in the new publication 'Enjoy Life Forever!—An Interactive Bible Course' (see screenshot).

image

https://download-a.akamaihd.net/files/media_publication/47/lffi_E.jwpub

AntonyCorbett commented 3 years ago

@abdon-copper Now supported. Thanks for your help