search

AntonyCorbett / JWLMerge

Utility to merge jwlibrary backup files
MIT License
195 stars 34 forks source link

Bookmarks not in right order #6

Closed DavidIQ closed 6 years ago

DavidIQ commented 6 years ago

I have merged 2 jwlibrary files with bookmarks not being present for one of the two. The one with bookmarks was the iPad and the bookmarks for my Bible look like this: 2018-07-04 18 29 26

On my Pixel 2 XL, which was the source of the other backup file and where there were no bookmarks for my Bible, this is the result of restoring that merged backup: screenshot_20180704-182931

So it looks like perhaps the way of calculating the slot number for the bookmarks needs a bit of tweaking as it almost seems random. The slot numbers seem ok in the iPad's backup: image

AntonyCorbett commented 6 years ago

@DavidIQ Thanks - I have updated the code to ensure bookmarks retain original order

DavidIQ commented 6 years ago

Thanks @AntonyCorbett I'll build and try it out later. I'm also working on adding option parameters to the cli. You accept PRs I assume?

AntonyCorbett commented 6 years ago

@DavidIQ PRs are fine. Please follow the style. Thanks!