AntonyCorbett / JWLMerge

Utility to merge jwlibrary backup files
MIT License
194 stars 33 forks source link

Merge file restore date not date of newest backup #64

Open schoenwaldnils opened 2 years ago

schoenwaldnils commented 2 years ago

When merging two backups I sometimes have the restore date of the older backup when importing into JWLibrary

Steps to reproduce the behavior:

Expected behavior I wasn't entirely sure if this is a bug or a feature. But in my opinion I'd expect the restore date of the newest of the backups

Desktop:

jayrtom commented 2 years ago

Replicated also on windows 11. It happens everytime in my case

AntonyCorbett commented 2 years ago

@schoenwaldnils - yes it looks like a "last modified" date is used from one of the original backups. I would suggest this should be updated to the date of the merge operation. What do you think?

schoenwaldnils commented 2 years ago

The date of the original backup shows the date of the last modification of the personal study notes. So I'd expect the date in the merged backup to be the date of the newest modification date across all files to merge 🤔

AntonyCorbett commented 2 years ago

My argument is that the last modification was made during the merge operation. But your suggestion is reasonable too.

schoenwaldnils commented 2 years ago

Yes, I know what you mean. I'm just thinking when I create a backup in JWLibrary the last modified date is the date when I last changed a note or highlightes something. Not the date I created the backup 🤔 Thats why I'd excpect to show the latest addition or change of the notes in the merged files 😁

But I don't want to split hairs 😅 Main thing is that its not older that one of the backups that are merged