AntonyCorbett / JWLMerge

Utility to merge jwlibrary backup files
MIT License
195 stars 34 forks source link

Use Version class for version check #9

Closed DavidIQ closed 5 years ago

DavidIQ commented 5 years ago

Thanks for sending a pull request! Please review the guidelines for contributing, then fill out the blanks below.

What does this implement/fix? Explain your changes

The version currently in the repo is 1.0.0.19 while the released version is 1.0.0.18. Because the version check is only checking for inequality the locally built app is incorrectly giving a "update available" message. To fix this the Version class was leveraged for doing version comparisons.

Does this close any currently open issues?

No.

Any other comments?

Thanks for reviewing.

AntonyCorbett commented 5 years ago

@DavidIQ Thank you David