AntonyCorbett / OnlyR

Simple Windows Audio Recorder
MIT License
93 stars 13 forks source link

Added feature that allows a recording to automatically stop after a specified period of silence has been detected. The settings page has been updated to enable/disable this feature, as well as specify the period of silence from a preselected list of presets. Translation resource files were taken from the Google translate service and have not been verified by native language speakers.. #66

Closed josemh closed 4 years ago

josemh commented 4 years ago

Thanks for sending a pull request! Please review the guidelines for contributing, then fill out the blanks below.

What does this implement/fix? Explain your changes

This change adds the ability to set the active recording to automatically stop after a specified period of silence. If OnlyR is set to start automatically and record for a maximum period of time (e.g. 2 hours), it is likely that it will record silence after the meeting has finished. This will allow OnlyR to monitor for such silence and automatically stop the recording.

Does this close any currently open issues?

No.

Any other comments?

Resource file translations were taken from Google translate. They have not been verified for accuracy or proper translation by someone that speaks those languages.

josemh commented 4 years ago

I have pushed fixed that I believe address all the issues you raised.

AntonyCorbett commented 4 years ago

Please would you remove all resx files from the PR other than the native one. These are not generated withing VS but by the Crowdin localisation tool. Sorry - I'll make this clear in the instructions.