search

AntonyCorbett / OnlyT

Meeting Timer
MIT License
113 stars 46 forks source link

Update GreenYellowRedSelector.cs #530

Closed jericusdegamuz closed 3 days ago

jericusdegamuz commented 3 days ago

Changes to yellow with one minute remaining. Recommended for Assembly or Convention use.

Thanks for sending a pull request! Please review the guidelines for contributing, then fill out the blanks below.

What does this implement/fix? Explain your changes

Instead of 30 seconds, color changes to yellow with 60 seconds remaining. This setup is recommended for Assembly or Convention use.

Does this close any currently open issues?

…

Any other comments?

…

AntonyCorbett commented 3 days ago

Thanks for your PR. The change would break the current behaviour. At the very least, I suggest this would need to be implemented as a user-defined option with a default of 30 seconds.

AntonyCorbett commented 1 day ago

@jericusdegamuz A neat implementation would be to add a duration attribute called "closing" (or similar) to the file-based schedule items. This would allow you to specify a bespoke value for each item. The "auto" implementation would remain unchanged.