search

Antriel / phaser-ts2hx

Convert Phaser's TypeScript definitions to Haxe externs.
MIT License
3 stars 1 forks source link

Phaser and PIXI shouldn't be root level scoped #2

Open hexonaut opened 7 years ago

hexonaut commented 7 years ago

I've moved these two into their respective package levels in haxe-phaser. It's rare that a library should add something to the root scope. Something you may want to consider for your compiler.

Ex) Phaser -> phaser.Phaser

Antriel commented 7 years ago

Yes, I wasn't entirely sure what to do here. On one hand, I didn't want to pollute the root. On the other, I wanted examples and snippets of Phaser code to be usable as close to their verbatim form as possible. So Phaser.Sprite would turn into phaser.Sprite. Same goes for Phaser itself.
But I guess I could move those two classes to their packages explicitly.

If anyone else has a preference, please let me know.