Antynea / grub-btrfs

Include btrfs snapshots at boot options. (Grub menu)
GNU General Public License v3.0
745 stars 77 forks source link

add support for yabsnap snapshot information #318

Closed 64-bitman closed 7 months ago

64-bitman commented 7 months ago

Yabsnap is equivalent to OpenSUSE's snapper but made for Arch Linux

This PR adds support for parsing the information from the json metadata files that yabsnap uses to track comments and triggers (type). There is no set name for the metadata files, its just the name of the snapshot + "-meta.json", and the files are located in the same directory where its respective snapshot lives

Schievel1 commented 7 months ago

Could you also edit the Readme a bit and mention this new program we support? Have you also tested how grub-btfsd behaves with yabsnap? If it's the same like snapper, e.g. keeping all the snapshots in /.snapshots, or any other directory, that is just there and does not disappear, this should work right out of the box. Timeshift does a few very special things.

64-bitman commented 7 months ago

Have you also tested how grub-btfsd behaves with yabsnap?

Yes and it works fine on my end, its very similar to snapper

64-bitman commented 7 months ago

I think this PR is ready now

Schievel1 commented 7 months ago

thank you very much for your contribution