AnubisNekhet / AnuPpuccin

Personal theme for Obsidian
GNU General Public License v3.0
1.99k stars 159 forks source link

[Bug] Amoled Dark theme makes code snippet impossible to read #236

Closed mathisgauthey closed 8 months ago

mathisgauthey commented 8 months ago

Describe the bug Hello there ! I'm using the AMOLED dark version of the dark theme on my Asus OLED laptop. It turns out that in dark mode, I can't see any code snippet whereas it is possible in light mode.

To Reproduce Use amoled dark mode.

Expected behavior Code snippet should have an aura surrounding the text.

Screenshots Light mode, we can see the code snippets : image

Dark mode, we can't : image

Additional context Settings :

Style settings :

{
  "anuppuccin-theme-settings@@anp-alt-rainbow-style": "anp-full-rainbow-color-toggle",
  "anuppuccin-theme-settings@@anp-custom-checkboxes": true,
  "anuppuccin-theme-settings-extended@@anp-theme-ext-amoled": true,
  "anuppuccin-theme-settings-extended@@anp-theme-ext-dark": true,
  "anuppuccin-theme-settings-extended@@anp-theme-ext-light": true,
  "anuppuccin-theme-settings@@anp-codeblock-numbers": true,
  "anuppuccin-theme-settings-extended@@catppuccin-theme-extended": "ctp-nord-light",
  "anuppuccin-theme-settings-extended@@catppuccin-theme-dark-extended": "ctp-nord-dark",
  "anuppuccin-theme-settings@@anuppuccin-accent-toggle": true
}

EDIT: I'm pretty sure that this is going to look well on an IPS screen. My question is two-sided :

ANOTHER EDIT:

Thanks in advance !

AnubisNekhet commented 8 months ago

Hi there! Thanks for pointing out the issue! I'm really sorry for not paying more attention to how the colors interacted with each other on different screens. Right now, AnuPpuccin is on hiatus, but I'll get around to fixing it very soon! For the time being, you can use this snippet:

body {
  --code-background: rgba(var(--ctp-surface0));
}

This should give your codeblocks a lighter color while still being readable enough against the text color.

mathisgauthey commented 8 months ago

Hi there! Thanks for pointing out the issue! I'm really sorry for not paying more attention to how the colors interacted with each other on different screens. Right now, AnuPpuccin is on hiatus, but I'll get around to fixing it very soon! For the time being, you can use this snippet:

body {
  --code-background: rgba(var(--ctp-surface0));
}

This should give your codeblocks a lighter color while still being readable enough against the text color.

Hey there, thanks for the input !

I'm using an automated way of switching theme on my computer, so I'd need to switch it manually each time this way.

So thanks, but I'll wait for it to be implemented and linked through the AMOLED dark and dark theme settings 💪

AnubisNekhet commented 8 months ago

No worries, this should help you isolate it to AnuPpuccin, specifically AMOLED:

.theme-dark.anp-theme-ext-amoled {
  --code-background: rgba(var(--ctp-surface0));
}
mathisgauthey commented 8 months ago

No worries, this should help you isolate it to AnuPpuccin, specifically AMOLED:

.theme-dark.anp-theme-ext-amoled {
  --code-background: rgba(var(--ctp-surface0));
}

2023-11-22 13_16_15.jpg